Pedro Maciel
Pedro Maciel
> Is it the intention to remove the feature CONVEX_HULL ? No, I accidentaly removed it when splitting branches. Thanks for spotting
> OK, thanks. There's still a change in how Qhull is detected after your last commit. Probably best to leave it as it was, without "REQUIRED_PACKAGES", and use `find_package(Qhull)` further....
@simondsmart poke!
> @pmaciel , is there a gridspec json schema available to test the validity of the input gridspecs? @sandorkertesz not yet :-) But the unit tests should be a guide...
> I've managed to go through everything, although I cannot claim that I was super careful everywhere with such large PR. I made all comments or suggestions in code. >...
> This looks really nice overall, despite the number of small comments. > > * You seem to really like things declared with __ at the start. This is supposed...
Sorry to have taken some time to return to this. So, eckit::Parametrisation is a eckit::Configuration's base class, with just the barebones interface full of pure virtual methods (like a Java...
(A possible Configuration::getValue could be just a redirect of the Configuration::lookUp method, which is currently protected).
> @pmaciel do you have a fix for this in another branch? My fix for it was to flatten the hierarchy, ie remove the nested SECTIONs. The work I have...
Can you write how it segfaults when running? So I can reproduce. I routinely build and test with eigen 3.4.0 (on both macOS/ARM64 and RHEL/amd64) and I don't find the...