Dimitris Platis

Results 72 comments of Dimitris Platis

We already have some sample (kinda incomplete) configuration for Travis, so why not? I have never used GitLab CI and CircleCI though, so I am open for pull requests :handshake:

:thinking: I've also seen it before. I tried to [reproduce](https://github.com/platisd/smartcar_shield/pull/55) it now but for some reason I can't. The Action completely ignored the remote branch for some reason :confused:, which...

I also think it'd work and would improve the run times. Feel free to submit a PR! :+1:

Sure, why not? The placeholder I2cMotor class was created with something like that in mind.

I suggest the following steps forward since I don't have this piece of HW: 1. Get your hands on the hardware 2. Make it work with some library/code 3. Send...

For me, the biggest problem begins with the fact that we use inheritance instead of composition for the sake of simplicity. ```cpp class ServoMotor : public Servo, public Motor {...

> Let's not ask me for suggestions on that first class problem else I'll end up proposing CRTP... :laughing: > Well I am not using the Arduino Framework at all,...

So what you propose is something like this (more or less pseudocode): ```cpp struct BasicServo { virtual void writeMicroseconds() = 0; virtual void attach(pin) = 0; }; struct Runtime {...

Well, should we really care about destructing the servo instances? To me it does not _physically_ make sense, considering the application domain we are in. In other words, if there...

> My point is that there is no difference in effort but one design allows direct user customization and the other simply doesn't so easily. Then we are back to...