Kevin Partington

Results 100 comments of Kevin Partington

Seems that `chain()` could be special-cased, and the chain object (`this` in the chained methods) could detect when the next call is no longer returning Backbone models and basically become...

The `remove` event itself is still fired on the collection, though, right?

It'd be great to have normalized hash decoding behavior, but the bit about breaking a browser's "back" button is highly concerning. - Have we established the exact impact (which browsers...

Would it be possible to create a repository demonstrating the issue?

:+1: from me for error on duplicate module name, with the caveat that I think it would have to be semver-major.

@trentmwillis What about call counts? If `before` for a given module is run multiple times as the test runner jumps around modules, that's not ideal either. Personally, I think we...

It definitely feels like a bug to me. On the browser, the tests would just hang indefinitely and the run would not be considered a passing run. I like the...

@leobalter Looks like the CLI should be handling this via [these lines in bin/run.js](https://github.com/qunitjs/qunit/blob/master/bin/run.js#L60-L66). But that code is not invoked when the Node API is used via `require("qunitjs")`. I'm not...

One challenge I'm running into is how to properly mock the `context.github.paginate` method. Is there an easy way to do that such that the mock matches its contracts, without having...

@not-an-aardvark Is that necessarily the case? Could we instead augment `parseForESLint` to support an AST errors property, and just report errors without linting if errors are present?