Philip Langer
Philip Langer
Just wanted to ping if someone would be available to give feedback to this proposal? :relaxed: Thanks a lot!
@msujew Did you have a chance to look at this PR? I'm looking forward to your feedback. Thanks a lot!
@vince-fugnitto @paul-marechal Thanks a lot for your feedback! I pushed an update which includes your suggestions.
Thanks again for your feedback! @paul-marechal You're right, we should filter package.json's deeply nested in dependencies. I've now added these two ignore globs: ```javascript `[^@]*/*/**/${PACKAGE_JSON}`, // package.json that isn't at...
I'll look into providing the actual functionality for `window.registerTerminalLinkProvider`. Also, in a first glance, I think it makes sense to harmonize this implementation with [`AbstractCmdClickTerminalContribution`](https://github.com/eclipse-theia/theia/blob/master/packages/terminal/src/browser/terminal-linkmatcher.ts#L25) and try to get rid...
@tsmaeder I've added a couple of issues for the remaining 1.55.2 API gap and updated the notes of the vscode-theia-comparator accordingly for existing issues and the new ones I created...
@tsmaeder I believe there is actually another one for 1.55.2: https://github.com/eclipse-theia/theia/issues/11521
I'll open a PR with a proposal soon.
It is not super-critical as I think this can easily be fixed in custom client styling, but still it doesn't look great by default.
:+1: for switching to peer dependency