Peter Lenahan

Results 11 comments of Peter Lenahan

Since `css-loader` and `css-object-loader` do very different things, they are not intended to be used together. `css-loader` will load CSS into `` tags, `css-object-loader` will load CSS into plain old...

Ahh you're right I was thinking of `style-loader` instead of `css-loader` there. For handling `@import` and `url(...)` statements, I think you're referring to supporting file loader like `css-loader` does right...

That plugin can be removed, it is there to solve a browser bug that has now been fixed by most browsers. As for updating the React version, I might give...

@WebExp0528 it looks like the version of `node-sass` here is old, and is not compatible with NodeJS v12. Can you try `npm install --save node-sass@latest`?

That's great news, I'll leave this issue open until I get a chance to update the `package.json` and commit the new version.

Hi @CedarDCX, I found that you can override this behavior by using `target="_blank"`, or using an absolute URL including the protocol. The check for this is performed [here](https://github.com/developit/preact-router/blob/ed0848eae07efa26f89a46fa4b4f40f7a146e128/src/index.js#L88-L89). It would...

@alvarotrigo I've also encountered this error, it seems like compatibility with Webpack 4 was lost in version `@fullpage/[email protected]`. Everything works fine in Webpack 5. Here is how I was able...

For now I think it would be enough to recommend Webpack 4 users only install `0.1.19`. I gave this a try for an hour today and messed around with the...

I believe this is currently not possible based on the invocation of `dataIdFromObject`: https://github.com/apollographql/apollo-client/blob/45540d5367673ceaa722e680b92fe5652512f511/packages/apollo-cache-inmemory/src/writeToStore.ts#L379-L380 I would also find it useful to access variables from the `dataIdFromObject` function, because I would...

It's worth noting that when the `Animate` component unmounts, it does not call `onAnimationEnd`. This makes it impossible for `recharts` to clean up any outstanding animations when `Animate` unmounts. Perhaps...