Pavithra Kodmad
Pavithra Kodmad
To gain full context, is this a refactor of existing design or is there scope to make any design changes? A few I can think that came up during the...
This is just an example from the documentation. What would warranty maintaining a gitter room for this?
Sure. its [email protected]
Thanks so much for your inputs @yaili ! This is shaping so well. Look forward to our meeting next week.
Closing this as I've already opened a PR for primer repo
Closing this PR. Basically after discussion with @siddharthkp and reviewing Chakra library, I think it's better we use [styled system's responsive props](https://styled-system.com/responsive-styles) to power this hide behaviour. I will update...
After some more thought and trying out the alternative `sx` way of having responsive css, I'm somewhat gravitating back to the simplicity and utility of this component. I have addressed...
I ran `npm run build` and got all tests to pass.
@siddharthkp - Thanks so much for your comments. Re- Deep storybook integration. We are already pretty deep into storybooks. We use them for all primer properties, most people are familiar...
Actually would be amazing to get rid of enzyme all together! Maybe during next passion week 🤗