Paul Johnston
Paul Johnston
@jsturtevant could you keep a cluster around next time this repros? Tried just now to repro with that aks-engine template but am getting the error: "VM has reported a failure...
Any chance you could include `azure-vnet.log*` in those logs? Saw that you [made a fix](https://github.com/Azure/aks-engine/pull/4154) to collect them. A new version would most likely not fix the issue, we have...
@copilot, can you fix the linting errors?
Hi @copilot , I still see a few linting errors, would you mind fixing those?
@copilot can you rebase, and try to fix all linting issues?
In particular @copilot I am seeing in hnsclient_windows.go do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"Failed to delete endpoint: %s (%s). Error: %v\",\n\tendpoint.Name, endpoint.Id, err)" (err113) and...
Hi @copilot I see linting errors for windows, can you fix those please? Error: level=error msg="[linters_context] typechecking error: D:\\a\\azure-container-networking\\azure-container-networking\\cns\\endpointmanager\\endpointmanager_windows.go:7:2: could not import github.com/Azure/azure-container-networking/cns/hnsclient (-: # github.com/Azure/azure-container-networking/cns/hnsclient\ncns\\hnsclient\\hnsclient_windows.go:18:2: errors redeclared in this...
Hey nice @copilot you fixed that linting issue Now however, I see one more issue in Docker Base Images: Changes detected. Please run 'make dockerfiles' locally to update the base...
@copilot there's a merge conflict, can you fix that? Just use the latest of what's on tip of master branch