Peter Mattingly

some _.merge instance can't be replaced with Object.assgn; Those files are: ``` /lib/classes/service.js /lib/plugins/aws/package/compile/events/cloud-front.js /lib/plugins/aws/package/compile/events/cognito-user-pool.js /lib/plugins/aws/package/compile/events/alb/lib/permissions.js /lib/plugins/aws/package/compile/events/api-gateway/lib/usage-plan.js /lib/plugins/aws/package/compile/events/api-gateway/lib/method/index.js /lib/plugins/aws/package/lib/merge-custom-provider-resources.js ``` Some files had no tests, and so were not modifed;...

@medikoo > please confirm also by running integration tests, that we did not break anything Will do. > I would also add a comment in each case where we leave...

Exactly. Thanks for weighing in! On Tue, Jul 26, 2022 at 1:43 AM Mariusz Nowak ***@***.***> wrote: > If so, then it might be worth making / finding code to...

Integration tests look good. Next, adding notes about why leaving in some `_.merge()`s. Then, getting a closer look at each change to determine the inputs and outputs, and what other...

Okay, will do. I as making notes to show progress toward completion; It helps me remember what I was doing with this PR. Is that okay?

Dissapointingly I could not remove `_.set` from any of its instances in customer facing code. Oddly, some instances of `_.set` seem to correspond to calls that are never run? Specifically,...

@pgrzesik Documentation seems to be a good first step. But I wonder if it would be possible to detect a Python environment and skip or run tests based on that?...

@pgrzesik I made some small documentation changes to note this; See: https://github.com/serverless/serverless/pull/11298

This issue also implies that the CI checks may not be checking for issues like this; That is, errors that might crop up during development.

Added small notice in CONTRIBUTING.md about recommended dev environment. And removed changes to package.json.