Philip Jenvey

Results 49 issues of Philip Jenvey

It's common to convert between different Error types using From conversions (the popular error_chain and failure crates both promote this). Rust's try! automatically calls .into() to facilitate these conversions. into_outcome...

suggestion

Restricting the global update setting to e.g. "update: insecure" doesn't seem to apply to manually specified requirements files (when they don't explicitly configure their own update setting) E.g. ``` update:...

bug

After an older gitter conversation, slog_scope's default global logger was changed to default to panic!()ing when the logger guard goes out of scope. I think this is a bad default,...

After [moving off travis](https://github.com/mozilla/rkv/issues/213) we should add a `cargo audit` run to the CI job.

Per https://github.com/mozilla-services/autopush-rs/pull/268#pullrequestreview-626695933: The `encryption_key` struct field and `enckey` entry in the router message data were only needed for `aesgcm128` support which is no longer supported. We should remove these (and...

good first bug
2
cleanup

We're using some of the autopush Python code for testing, but we've duplicated much of its integration testing bits in our own `tests/`. Removing the last references to it (either...

enhancement
good first bug
3
cleanup

Logging this separately from #132 as it'll be its own chunk of work. This is the most recent hyper released a couple months ago, switching everything to `std::future::Future` (and associated...

enhancement
5

Per https://sentry.prod.mozaws.net/operations/autopush-prod/issues/7863037/ We should include the actual error's message that caused these.

enhancement

Notifications include a created at time (the `timestamp` field). Assuming the endpoint and connection nodes clocks are accurate/in sync, we should be able to track the total time taken from...

3

Let's ensure there's documentation in place for self hosters. Our README may already cover most of what they need: let's double check if there's anything to add. It should be...

enhancement
3
community
self-hosting-phase2