Andrew White

Results 36 comments of Andrew White

@luislavena that all sounds fine - will take some time over the Christmas break to bring things up to speed.

@BigGillyStyle have you started on your PR? I have a fix just about ready to go but can work with you to make a PR.

@nijikon I think there's actually two scenarios we need to address 1. **Rails 3.2.x** Copy across `app.secrets.secret_token` 2. **Rails 4.0.x** Copy across `app.secrets.secret_key_base` and `app.secrets.secret_token` but only if they are...

I can see that getting legitimate test files for some of these could be fraught with issues - Genesis ROMs for example 😬

Also not all of the differences are bugs - for example `serafettin.rar` returns `application/pdf` in 0.3.3 which is obviously wrong so we shouldn't change that back (though there's still a...

Adding an entry to the test matrix for Active Storage by itself with an API app seems a bit icky but didn't seem to be an obvious solution otherwise -...

@jcoyne completely forgot I opened this - I'll have a look at whether we can just use the api controller as the parent controller as Matthew suggested.

@btir @jcoyne looks like I'll have time to get this sorted this week so 🤞 for Rails 6.1