Piotr Piwoński

Results 15 comments of Piotr Piwoński

Post-install script prevents installation

The issue seem to affect users installing `starknet-js` via yarn too as it depends on github branch currently. Although error messages are not clear. Installing via npm works fine though.

Transpilation abandoned Import warp_external_input_check_int256 from warplib.maths.external_input_check_ints is not defined.

Thanks for reaching us out! It seems like for some reason `external_input_check_ints` was not generated. Does the file exist in the container? `yarn warplib` should save it under the path...

Transpilation abandoned Import warp_external_input_check_int256 from warplib.maths.external_input_check_ints is not defined.

Exactly what @akasimo wrote. I'll just add that there are two directories because docker-compose was designed to be used both by warp developers and users. `warp-stable/` is added in Dockerfile...

Transpilation abandoned Import warp_external_input_check_int256 from warplib.maths.external_input_check_ints is not defined.

I've created an issue #1011 for that. @tutan123 @akasimo I'd be happy to hear your opinions

Use `toCairoUint256` in tests

@pratham-bhatnagar sure!

Run grammar checker as a part of CI

They're soon to be merged. For now you can work on the [branch](https://github.com/NethermindEth/warp/pull/827)

Remove for loops variable mangling

Sure, done :)

Add conditionals to literalExpressionEvaluator pass

Passes are stored in `src/passes` so you can find that in `src/passes/literalExpressionEvaluator/literalExpressionEvaluator.ts`

Add debug documentation

@AlejandroLabourdette you don't have to store it in a file. You can use less as in the example I provided above

Handle literals

Honestly I don't have a strong opinion on that. I agree that typestring parser is not an option long term. I'd see that rather as a temporary solution to fix...