Hans van Luttikhuizen-Ross
Hans van Luttikhuizen-Ross
Duplicate of #56.
Can this PR be looked at? Using `protected` rather than public is the documented way of using this functionality and prevents accidentally calling the method instead of the magic property.
> Will soon check it out; this competes with #1325 right? Correct.
I would like to ask if someone could look into this again. The summary states the case/necessity for this PR. There are some fairly major changes to `ModelsCommand.php`, but all...
I would like to update this PR, but it relies on #1338. I would like to note that this PR is required to support the Attribute accessors that are new...
I would love to see this improvement made to be able to adhere to the recommended code style.
In general, if you add a feature or fix a bug, you write tests for it to prove that it works since the existing tests won't point that out. It's...
> A little question, the PR works with "untyped get attributes", but what happen with "untyped set attributes"? Because of this I added a lot more tests including a few...
@mfn could you look at this PR? Its changes are well described and there's tests for both the happy path as well as a few edge cases.
I would like to have this PR merged so that I can update #1339, which is required for the proper usage of the Attribute accessors that came with Laravel 9.