Leo Sjöberg

Results 25 comments of Leo Sjöberg

@nicja thoughts on trying to get some tests in here? I'm wondering if @ralfiannor should perhaps at least add a test for the config merging, but that would require some...

@nicja this issue has wreaked havoc on us today. We need the ability to set `'key_file' => null` as per the proposed PR. I don't actually see why we need...

That looks like it would do it indeed @nicja

One thing I realised while talking to @hickeyma was that the docs I submitted in #623 are a bit off as the example used there is `nginx:1.10`, this won't work...

Yep, save function. I fixed it locally for myself, I can either fork you and make a PR, or if you have time to add it yourself, that'd be great....

It would also be cool if you'd add in a `saveData` attribute to the options, so that users could extend `gm` with their own request data (such as a page...

Is there a branch on which you're developing the next version/another repo where I could contribute?

Grand. I'm no major JS developer either, work mainly in backend, but I work pretty closely with a front-end dev here, and sometimes I end up helping her with things,...

Gonna have a look later tonight! I'll probably fork you and do some PRs; I've implemented a couple features for my own project which I could just pull in and...