Christian Ebert

buildCSSClass seems to have no effect?

9

Very simple example: ```js var ControlBar = videojs.getComponent('ControlBar'); var TitleBar = videojs.extend(ControlBar, { buildCSSClass: function () { return 'vjs-control-bar vjs-title-bar'; }, constructor: function (player) { ControlBar.call(this, player); videojs.dom.textContent(this.el(), 'MOVIE TITLE');...

With recent changes shutil now tries (and fails silently) to remove a tree with path generated here: https://github.com/flavioribeiro/video-thumbnail-generator/blob/master/generator#L195 which is actually the so-called 'prefix' of the temporary png filenames. shutil...

Is HLS aes encryption supposed to work for fmp4?

4

Not the full template, just a question. Here's [an example](https://phloxic.productions/test/vjs-simple.html) of an aes encrypted fmp4 HLS VOD stream, segmented by mediafilesegmenter. Plays fine in Safari. http-streaming barks: 'RangeError: buffer length...

Dash: overrideNative affects behaviour in Safari

5

## Description If `overrideNative` is not set (the default for Safari), the player hangs on seek. This does not happen with `overrideNative: true`. Can be observed in the [netlify test...

cacheEncryptionKeys has no effect with subtitle streams

9

## Description Reduced test case can be found [here](https://phloxic.productions/test/videojs/cachevttkeys.html). ## Steps to reproduce 1. AES encrypted HLS source with subtitle stream 2. set `cacheEncryptionKeys: true` 3. play and monitor GETting...

AES-128 encrypted fmp4 stream does not play

4

## Description The problem can be reproduced in the [netlify demo](https://videojs-http-streaming.netlify.app/?debug=false&autoplay=false&muted=false&fluid=false&minified=false&sync-workers=false&liveui=true&llhls=false&url=https%3A%2F%2Fd12zt1n3pd4xhr.cloudfront.net%2Fdev%2Ffmp4-aes-en-nif.m3u8&type=application%2Fx-mpegURL&keysystems=&buffer-water=false&exact-manifest-timings=false&pixel-diff-selector=false&network-info=false&dts-offset=false&override-native=true&preload=auto&mirror-source=true) The same stream plays fine in macOS Safari [when overrideNative is turned off](https://videojs-http-streaming.netlify.app/?debug=false&autoplay=false&muted=false&fluid=false&minified=false&sync-workers=false&liveui=true&llhls=false&url=https%3A%2F%2Fd12zt1n3pd4xhr.cloudfront.net%2Fdev%2Ffmp4-aes-en-nif.m3u8&type=application%2Fx-mpegURL&keysystems=&buffer-water=false&exact-manifest-timings=false&pixel-diff-selector=false&network-info=false&dts-offset=false&override-native=false&preload=auto&mirror-source=true). – Disclaimer: Did not test on...

At the moment the initial check for the presence and order of components [does not behave well on failure](https://github.com/phloxic/videojs-sprite-thumbnails/issues/55#issuecomment-1837965935). The plugin should bail out cleanly if the required components are...

time tooltip out of bounds on the right of player

2

Since Video.js version 7.9.4 the time tooltips can go out of bounds on the right side of the player. See e.g. https://github.com/videojs/video.js/issues/7248 and not accepted fix https://github.com/videojs/video.js/pull/7308 et.al. This affects...

chore(css): fix typo in postcss-config browserslist and update list

1

- s/last 3 major version/last 3 major versions/ - sync with current browserslistrc, babelrc, rollup_config ## Requirements Checklist - [ ] Feature implemented / Bug fixed - [ ] If...