Philipp Rumpf
Philipp Rumpf
Hmm. I've added some basic tests, but the 14.x tests appear to be failing in unrelated tests. Is this expected?
@atarix83 Thanks! That makes sense, yes, I'll make the change.
@tdonohue Thanks! @atarix83 Thanks again for the review. I've updated the PR.
I agree this particular PR addresses a problem that no longer happens (or at least happens differently - if I notice it again, I'll open a new PR against 7.4)
Oh, thank you! I'd missed that, somehow (or thought it was about the "null" -> null thing). I guess we can't do anything about it for now.
I got stuck trying to figure out how to write a test for this, to be honest. For now, I've submitted a PR without the test.
Thanks for your response, and sorry for leaving it for a while. We had considered both approaches, but now I've had time to think about it I prefer yours. I'm...
There's an initial patch series at https://github.com/DSpace/DSpace/compare/main...philipprumpf:DSpace:issue-8469?expand=1 that may illustrate what we're trying to do (it's probably not a good idea to attempt to run it yet). In short, we...
As for the case sensitivity of BibTeX tags: http://www.bibtex.org/Format/ states "The tag's name is not case-sensitive", so I think the .toLower() is the right thing to do.
Thanks for the response! I've added a test for diacritics and will add tests to the other PRs as suggested.