Philip Nee
Philip Nee
👋 new to the rust world. For the question on what should the client do if losing connection to the coordinTor, the client should try to reconnect. If the poll...
it would be (very) nice to have a rust native kafka client instead of wrapping around librdkafka. And yes, consumers should retry until timeout.
cc @guozhangwang @hachikuji @dajac for review.
Thanks @hachikuji and @guozhangwang - I just updated the PR. I'm settling with `ApplicationEvent` and `BackgroundEvent`. Also, brief definitions for the abstract classes have been added.
Thanks @guozhangwang! Agreed, we can make incremental changes to these implementation as we make more progress.
@ijuma - I think @hachikuji is reviewing it.
Hey @hachikuji - Thanks for the previous review, but I rewrote the PR because of some of the timeout IT tests. In the previous version, the issue was that simply...
Hey @jolshan - Thanks for the review. i reverted those documentation/comment changes in the senderTest.java (for the produceResponse authorization error).
Failing tests don't seem to be related. ``` Build / JDK 8 and Scala 2.12 / testReplicationIsCreatingTopicsUsingProvidedForwardingAdmin() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest 1m 46s Build / JDK 8 and Scala 2.12 / testSyncTopicConfigUseProvidedForwardingAdmin()...