Philipp Dresselmann
Philipp Dresselmann
The problem isn't always observable under MSVC, but it's still there. I found that crashes become almost guaranteed when adding some debug output to [WaveShaperNode::processCurve](https://github.com/LabSound/LabSound/blob/55b5934dbb74490d8a3a7b85faad85205ab5ee5b/src/core/WaveShaperNode.cpp#L109C24-L109C24), for example, but that's only...
> ... I've pushed the patches to `main` as it makes things cleaner overall, and if you have a chance to test, could you LMK if you still get the...
FWIW, running the example with `-fsanitize=thread -fno-omit-frame-pointer` yields [some warnings](https://gist.github.com/pdresselm/b819b3577058d60a1d78d99d328506f8). I don't have time to look into these (or do testing on other machines) right now, but it might be...
Back to testing on native Linux now. The corruption is definitely still there. Presumably, it's the same problem. Symptoms: * SEGFAULT in [AudioContext::currentTime()](https://github.com/LabSound/LabSound/blob/5cbd248e8ed24ba33278a42830cbefef053fb239/src/core/AudioContext.cpp#L680) because `_destinationNode` is `nullptr` (I added an...
> Is the crash at the end of the demo? I just got repro due to deleting the ShaperNode while it was still processing in the audio thread. Crashes seem...
I pulled in the latest changes (3ba7b4975f47b4f6303049ecd0c3d1e07b6db0a2, previously on 9975447ab9aa87b36b94befe0a0ffef42f1619e8. SEGFAULT and garbled audio still observable. Additionally, the WaveShaperNode example now fails this assertion: `LabSound/src/core/AudioNode.cpp:426 - _self->m_channelCount != 0 `
The good news is that the RtAudio upgrade seems to have resolved the "garbled audio" (Linux-only) issue, as far as I can tell. Still on Linux, there are a few...
Thanks for your effort! It seems there are significantly fewer data races, though some must still exist. Remaining issues: * Oversampling introduces the "buzzing sound" still, as previously mentioned *...
Just observed another crash, this time with MSVC: ```sh A i 0 curve[0] -0.342995 curve[44099] 0.342989 oversample none A i 1 curve[0] -0.344421 curve[44099] 0.344417 oversample none A i 2...
> How are you doing this? If you have a command line or script to share, I can start doing the same thing here. Just running the program in a...