Phap Dinh comments

Results 6 comments of


                                            Phap Dinh

used decaffeinate to convert coffeescript into javascript

I can take the javascript files that are generated from grunt and replace the coffeescript files with those files instead of using decaffeinate. Those javascript files are what are actually...

used decaffeinate to convert coffeescript into javascript

I can create a separate PR for that one

Convert to plain JavaScript (or perhaps ES6 with Babel)

@sorccu can we start by converting the grunt file from CS to JS? I can create a PR for it

Convert to plain JavaScript (or perhaps ES6 with Babel)

this PR has existed to convert only the grunt file to javascript for a while and it has no merge conflicts https://github.com/openstf/adbkit/pull/122/files

@types/lodash is listed as a dependency for react-json-tree when it should be a dev dependency

we could at least move it into a dev dependency to reduce package size

@types/lodash is listed as a dependency for react-json-tree when it should be a dev dependency

@Methuselah96 react-json-tree is only an internal tool used by react-dev-tools. from my understanding, react-json-tree is not exposing any of it's types for use by any consuming package. declaration files that...