Paul Fultz II

On Mon, 2017-07-24 at 05:22 +0000, Michael H. Cox wrote: > @mikehcox commented on this pull request. > In doc/src/Intro.rst: > > @@ -76,6 +90,12 @@ For dependencies on other...

I think this can be accomplished with the `PASS_REGULAR_EXPRESSION` or `FAIL_REGULAR_EXPRESSION`, but let me create a test for this use case.

> I don't think it works That looks like what you do in the link you sent. > it's convenient to put the error message in the source file Yea,...

I actually don't see it as backwards. However, I do see it very useful to add a feature to parse this from the source files.

We would need support for pkgconfig in hip first before it could be implemented in rocblas. Also, any generation of pkgconfig files needs to be done by rocm-cmake to ensure...

> I will also get rid of the using namespace ValueFlow within the split files since it makes things harder to understand when the increased granularity kicks in. Wrapping in...

> I don't like that the indentation is being increased by that. I think it's nicer to simply add a single line and having them all aligned to the first...

Dont build dependencies directly using `FetchContent`. This prevents the project from being built without an internet connection. It prevents distro maintainers from using their own prebuilt dependencies to build the...

> This warning cannot be disabled "safely" or re-directed, and repeated warnings cannot be consolidated to avoid clogging screen output The warning shouldn't be ignored. And this case its even...

This is a bug in gcc. They don't support defining auto constexpr variables within template contexts. I don't if they have fixed it in gcc 4.8. However, it will work...