Paul Fultz II
Paul Fultz II
So `PRIVATE` means its not a user facing file, and is only used internally by the library. As such, it should be installed when using asan and not asan builds....
> Should there then be a flag to force a target to be ignored in the ASAN build, in addition to this PRIVATE flag? No, we should just ignore everything...
> is there any work required for this ticket? Yes. > Can I close it? No.
> is there any work needed for this ticket? Yes docs and test needs to be added for `rocm_set_soversion` function.
Can this be reviewed?
It seems jenkins isn't running on this anymore. Let me fix that.
Nevermind, jenkins was never enabled. Can you add a test for the `-c` option?
It should depend directly on the compiler and device libs, and not use the metapackage(which can bring in requirements we may not want).
Its supposed to be boost license.
> It is too tied to how Boost builds things and/or has incompatible Boost-specific workarounds. The `bcm_boost_package` is very boost-specific, however, the rest of the functions can work with any...