Petr Hosek

Results 12 comments of Petr Hosek

Yes, that's the correct use. However, the documentation at this point is explaining the intended use rather than the actual state. I've already added the missing file, but please bear...

Clang should add that include path automatically, see https://github.com/llvm/llvm-project/blob/13b8362f02dc8da35512c3e9204632760cfb367a/clang/lib/Driver/ToolChains/Gnu.cpp#L3073-L3076 I think the issue here is the triple. You pass `--target=arm-linux-gnueabihf` (that is 32-bit ARM Linux) but also `-march=armv8-a -mcpu=cortex-a72` which...

Yes, normalizing triples in `LLVM_RUNTIME_TARGETS ` is planned, but there's some groundwork we need to do first.

This'll have to be updated once you land #98, but that should be pretty straightforward.

I'd be interested in seeing this merged as well since we need this change for the https://github.com/google/ml-compiler-opt project. @Maratyszcza would it be possible to take a look?

I'd be interested in seeing this merged as well since we need this change for the https://github.com/google/ml-compiler-opt project. @Maratyszcza would it be possible to take a look?

I don't think the `isnan*` tests should live in `test/include`, they should live in `test/src/math` to mirror implementation in `src/math` just like we did for all other math functions. The...

FYI I have a PR #98274 for the `isnan*` tests in `test/src/math`.

`localtime_r` is under development, see https://github.com/llvm/llvm-project/pull/110363.

> > IIUC MinSizeRel was only used to save space in the github actions workers, but if we build all three then that doesn't make as much sense. > >...