Pete
Pete
Fixed in df1c23d. Issue can be closed?
Why are all diffs showing up as full-file replacements? Did you change line ends?
I'd recommend rejecting this PR in its entirety. Commit descriptions should describe the change, not the file that's changed; that's easy to see elsewhere. White-space only commits (eg LF->CRLF) should...
Hey @jsumners. Thanks for submitting this PR and improving it. There have been a few submissions for creating a pid-file directly from the program, so this feature is obviously an...
I have no preference of one over the other. Unfortunately, one of you will be disappointed in either case, as it sounds you're both using your branch in production. I...
Ah, ok. I've been using it on Ubuntu systems, and it's launched from the helper script at /etc/network/if-up.d/ucarp, not directly from systemd. I'll take a gander at the RPM and...
You have Type=forking commented out in your service file there, which means it defaults to Type=simple, and there is no need for a pidfile at all. With Type=simple, systemd runs...
To add to that: > GuessMainPID= > Takes a boolean value that specifies whether systemd should try to guess the main PID of a service if it cannot be determined...
Yeah, it looks like the guy who put together the RPM for EPEL didn't put much work into making it compliant with systemd and making sure it works as as...
Thank you, @idl0r. This is a simple but useful enhancement. I'll likely be rebasing this and pulling it in soon.