Peter Trifanov

Results 83 comments of Peter Trifanov

> @bishiboosh @petertrr what do you think about kotest? I haven't tried kotest myself just yet, but I've read about it. Indeed, API looks nice and more kotlin-idiomatic. I was...

> use a single letter for generic types We actually have this logic in diktat, described [here](https://github.com/saveourtool/diktat/blob/master/info/guide/guide-chapter-1.md#-111-identifiers-naming-conventions)

> The issue can be worked around by modifying the default configuration: @0x6675636b796f75676974687562 I think can be considered not a workaround but rather the entire solution, because it's exactly what...

What if there are several overloads of function `foo` with the same number of arguments but different types? Then type of the lambda would be ambiguous. I guess it would...

I meant some weird corner cases like ```kotlin fun foo(f: (a: T, b: String) -> Unit) = Unit fun bar() { foo { _: Int, s -> println(s) } }...

We also have a flag to disable this grouping, since it's indeed sometimes a controversial style: https://github.com/saveourtool/diktat/blob/9e3b5cb7d1a84e103ad5020bed096279ad373eb1/diktat-rules/src/main/resources/diktat-analysis.yml#L160-L162 Setting `useRecommendedImportsOrder` to `false` will only keep alphabetical ordering without grouping

Hi @droidmatic34 , I am able to reproduce your error on [diktat-demo](https://ktlint-demo.herokuapp.com/) in `FIX` mode. Ditkat re-arranges declarations from the class body, and it places `object` before `fun`. However, it...

I've looked into it more, and I think it's an inconvenience of integration into spotless. Usually, diktat (as well as ktlint) checks files twice: at first it fixes everything it...

This is not actually a false positive, it's just a rule with poor wording of its findings :) According to [rule 3.1.5](https://github.com/saveourtool/diktat/blob/master/info/guide/diktat-coding-convention.md#-315-order-of-declaration-of-top-level-code-structures) of the code style, extension functions should be...

[minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example), I believe the whole body of `let` is not important here. Also, please provide original code when reporting autofixer issues. > But then an error is Please...