Peter Makowski

Results 41 issues of Peter Makowski

Hey @d4nyll, I am going to use lethargy in my project (thanks again, you're a life saver) and have started converting it to ES6 syntax (it was the only option...

enhancement

## Done - test: setup cypress This PR will be followed by another one that will [Add Cypress to CI tests](https://github.com/canonical/vanilla-framework/issues/4541) Fixes: https://github.com/canonical/vanilla-framework/issues/4538 ## QA - Run `yarn cypress:open` or...

Review: QA needed
Review: Code needed
Maintenance 🔨

## Done - add a transition to the accordion pattern Fixes https://github.com/canonical/vanilla-framework/issues/4539 ## QA - Open https://vanilla-framework-4542.demos.haus//docs/examples/patterns/accordion/default - Verify the accordion works as before with the addition of having a...

Review: Design needed
Review: QA needed
Review: Code needed

## Done - add expandable side navigation Fixes https://github.com/canonical/vanilla-squad/issues/1420 ## QA - Open [/docs/examples/patterns/side-navigation/expandable-docs](https://vanilla-framework-4536.demos.haus/docs/examples/patterns/side-navigation/expandable-docs) ### Check if PR is ready for release If this PR contains Vanilla SCSS code changes,...

Review: Design +1
Review: Code needed
Review: UX +1
Feature 🎁

Rename vf-animation to vf-transition https://github.com/search?p=2&q=org%3Acanonical+vf-animation&type=Code - [ ] Rename vf-animation to vf-transition - [ ] add `vf-animation` alias for `vf-transition` to prevent breaking changes - [ ] use a mixin...

Add Cypress to our CI tests pipeline (via GitHub actions).

Maintenance 🔨

## Done - add `jest` & `@testing-library/dom` dependencies and basic setup for integration tests with JSDOM - Add side navigation tests _Note:_ includes commits from https://github.com/canonical/vanilla-framework/pull/4536 ### Check if PR...

Don't merge
Maintenance 🔨

add accordion transition ![36n7a_jLBp 12 21](https://user-images.githubusercontent.com/7452681/185381319-ff7e3957-b3cf-4551-9ce4-d58156bdfef3.gif)

**Describe the bug** Tabs example suggests using semantics that's not supported and throws an accessibility error. "aria-selected is not supported on role link" We should investigate using different semantics when...

Priority: Medium
Bug 🐛
Accessibility
P3 Triaged
Triaged: v4