Pete Miller
Pete Miller
@javivelasco can we supply an example of how to override defaults with postcss plugins?
atom supports multiple root folders, so how would you know which opened source folder to look in?
Personally, I often work with multiple folders as separate components of a platform. Each is an individual app that I need to run as part of the platform. I would...
@johnhaley81 rebased but unfortunately test still fails intermittently (fails more often than succeeds). I ran the tests both with `NODEGIT_TEST_THREADSAFETY=true` and with `NodeGit.enableThreadSafety()` explicitly inside the test. Fails on both...
If I'm right in thinking that `addRule` does not need to be re-processed if `observable.rules()` changes, then the `peek` used in this PR is probably more appropriate. [As suggested by...
One last piece we need is a manual test plan for QA specified either in this PR or in the issue. Can you help with that @fallaciousreasoning ?
I added `todayStorybookState.ts` to SonarCloud's ignore list for code duplication analysis. Pushing a rebase in order to re-run...
I'll take a look at reviewing this, but I'll need to do a build to see the difference. I would suggest you append some more items the description: - Which...
Yeah it's looking pretty good at first glance of the screenshots. We'll want to get a designer to look over them to check the font-weight and size differences especially between...
I have done the brave-ui changes here: https://github.com/brave/brave-ui/pull/607 You can use this sha for testing that in this PR: `e4c049880199ac652b8f69610b8b70d1cd6d906f`