pepeshore

Results 20 comments of pepeshore

@raphw when will this issue be closed, we encounter this problem too

I have implemented the collection of thread pool metrics in my forked repository. including the following metrics: - thread_pool_core_pool_size - thread_pool_max_pool_size - thread_pool_active_thread_count - thread_pool_current_thread_count - thread_pool_max_thread_count - thread_pool_scheduled_task_count -...

> I think it is a reasonable request, but it is too vague. It would be helpful to know exactly which thread pools the users are interested it. It should...

> No, I don't. There are many ways one could implement a thread pool Indeed, there are many implementations of thread pools. However, it is sufficient to monitor the mainstream...

> Even something seemingly simple, like instrumenting `ThreadPoolExecutor`, immediately gets complicated when you consider that you somehow need to identify which `ThreadPoolExecutor` the metrics belong to. I considered this issue...

@laurit Hi laurit,What do you think about my opinion?I do think is't a useful feature

> @pepeshore sure, a PR would be welcome ok,assign this issue to me pls

> hi @pepeshore! have you seen the [Collector Tail-Based Sampler](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/tailsamplingprocessor)? yes,it's really a helpful approach, tks

> hen the collector is working in a separate cluster, the number of agent reports is too large ? Can the agent implement exception samplin See Tail-Based Sampler in SpanProcessor,...

It seems to be that JFinal will put all the attributes of a request into map, and then use FastJson to serialize the map. shown as below ![image](https://github.com/open-telemetry/opentelemetry-java-instrumentation/assets/26158117/daa6364b-e10e-40ae-99e8-d958b12512b7) And in...