Samuele Pedroni

Results 63 comments of Samuele Pedroni

What's the reasoning here, to reduce this to a single digit? Why exactly 4?

@AristoChen > snap prepare-image --channel=stable --snap=core22=latest/stable --snap=network-manager=22/stable --snap=modem-manager=latest/stable --snap=core=latest/stable model.assert work/unpack I don't understand what is the intention here, UC20+ models are meant to be self-contained and explicit (except for...

@AristoChen we recently changed how/when we check for bases in seedwriter, it's possible that is now works with a snap prepare-image using snapd from edge if and only if the...

@valentindavid can the description or some comment in the code include the actual udev rules that this will be used from? it's a bit unclear just from the code how...

after thinking a bit, as this has no clear equivalent `snap` command, my preference would be introduce this as `is-connected --list` instead of a fully separate new command

this seems to do more that what the summary says. About dealing with hooks we'll need to see what is our final design

> Separately: can we agree to move away from ###STUFF### replacements and move to text/template which is safer and more efficient. This is a follow-up for this but I just...

> If flag is disabled on startup and enabled later: System key will be set with prompting disabled, so listener will not start, so profile generation should never include prompt...

> Also IMO this PR is a bit too big, the path pattern expansion could be its own PR for instance if this PR could be split in two I...

I think this is also needs security review?