Pedro Lisboa
Pedro Lisboa
> This looks good so far! Though, there's one quirk about the style tag rendering that I misspoke about in the screenshot above. The expected output should actually look like...
> Probably best to add the prefix where it matters only, and render here without any change. > > Do you know why emotion doesn't need the "css-" prefix here?...
@davesnx I have to issue a mea culpa for not testing it on a project using a reasonml SSR. I'm going to take the @purefunctor details and going to make...
⚠️ To my future me ⚠️ It would be nice to have a demo of this feature on styleppx
I agree with @davesnx; it makes more sense to someone who wants to explicitly change the primitives to do it. I don't think having one config for that specific user...
@NathanReb Hey ya! > Did you try to load the resulting JSON into AST explorer? It would be nice to have a working usecase for this before we merge this...
@NathanReb BTW, I think now it's ready for review
> [ ](/pedrobslisboa) > ` [Add json mapper for pp_ast](/ocaml-ppx/ppxlib/pull/526/commits/6ae39ba9bf1b3d4514acf7a822076621ecd6c4a8) ` I tried to keep any json syntax away from pp_ast. ### What I did I exposed the `simple_value` contract...
> This looks good! I think you're right, that's the simplest and most flexible solution here. > > Could you add a couple tests in `test/ppxlib-pp-ast/`, a changelog entry and...
When you said, "update ppxlib-tools deps to reflect the changes?", what did you mean by that? I didn't get it. Besides that, I think I updated the remaining content. LMK...