Denis Limarev

Results 18 comments of Denis Limarev

@mem this issue about third party packages imported in rules such as this one for example: https://github.com/delivery-club/delivery-club-rules/blob/462a5e373a3d63ec51a8687cbb6dbc0379ac30b3/rules.go#L487

solutions that i can imagine now: - add option (disabled by default) which will skip rule if imported package doesn't exist in project - always skip rule if it doensn't...

another one solution: - filter func in Importer which can be called (if exist) after/before Import method

maybe for specific rules you can use pattern like this one: `m.Where(!m.File().Name.Matches("_test.go")))`

test data: ``` var globalVar *os.File func negative2() { globalVar, _ = ioutil.TempFile("", "") // global var kk := globalVar.Name() print(kk) } ``` rule: ``` func unclosedResource(m dsl.Matcher) { varEscapeFunction...

@jippi as i know `$$` it about expressions before statements in `match` method, i think you are looking for something like this: https://github.com/delivery-club/delivery-club-rules/blob/462a5e373a3d63ec51a8687cbb6dbc0379ac30b3/rules.go#L327 or if for whole function/package body: https://github.com/delivery-club/delivery-club-rules/blob/462a5e373a3d63ec51a8687cbb6dbc0379ac30b3/rules.go#L446

add tests projects with different go version according with: https://github.com/delivery-club/delivery-club-rules/issues/43

in first sight we can check some corner cases like in your example about 1.18: if you will build dcRules by go1.18 it will be able to lint projects under...

Did anyone knows how I can scale the button size right now?

@mcarpenter622 thanks for your answer, can you provide a code example? I don't know much about library context right now, so i don't know how to reproduce: >I could try...