Patrick Dubroy
Patrick Dubroy
@valerybugakov Is the intention here that this be an evergreen issue? Or is there a point where we can call this "done"?
Here's an [example](https://github.com/barbagroup/AeroPython/blob/master/lessons/01_Lesson01_sourceSink.ipynb) on GitHub. To me it looks like a significant chunk of work would be required to deliver a high-quality solution here. Given what @sourcegraph/frontend-platform has on the...
The problem is that the widget looks for AST nodes of type 'Literal', and by JavaScript's grammar, `-50` is a 'UnaryExpression' whose argument is the literal `50`: http://esprima.org/demo/parse.html?code=-50
I'll take a look at this tomorrow. If you have a chance, would you mind re-syncing with the latest from cdglabs:master and uploading a new PR that only includes the...
This is looking good! I'm happy to merge it as soon as you fix up the lint errors. Sorry it took a lot of back and forth, but I think...
I don't seem to get notifications when you push to this branch. Apart from the comments I just left, one more thing: the new files you've added are not being...
Yes, I prefer 2-space indentation -- but third-party code should remain unchanged. Which files are not using 2-space indentation now? I took a quick look and it seems like almost...
Yes, that's fine given the nature of the project. Might as well add a global exception.
It all looks good, but one more problem -- the tests are failing. I think the simplest way to fix it would just be to move the client Channel into...
It's a bit of a hack, but sure, something like that is fine for now.