Peter C. Jentsch

I feel like this is a correctness issue that should addressed sooner rather than later. I ran into it back in march. At minimum, I think the documentation should address...

@StefanKarpinski to clarify, you are saying that the behaviour should be: ``` symdiff(a::AbstractVector, b::AbstractVector) = collect(symdiff(Set(a), Set(b))) ``` right? Not that this is a good implementation, just a correct one.

I see this bug in VSCode on the insider branch regularly recently.

Switching to stable on VSCode fixes it for me.

It looks like you might be hitting a lot of compilation time? I am not sure if `@time` counts `GPUCompiler` compilation time in its reporting of "8.85% compilation time". Exchanging...

As I mentioned in my reply in #46776, with this implementation, `eigen(A::Diagonal,B::Diagonal) != eigen(Matrix(A),B::Diagonal) != eigen(Matrix(A),Matrix(B))` despite these all representing the same matrices, but I think this would hold for...

I think this should work yes. The easy fix would be to define ``` eigen!(A::AbstractMatrix,B::Diagonal; sortby::Union{Function,Nothing}=nothing) = eigen!(A, Matrix(B);sortby) eigen(A::Diagonal,B::AbstractMatrix; sortby::Union{Function,Nothing}=nothing) = eigen(Matrix(A), B;sortby) eigen(A::Diagonal,B::Diagonal;sortby::Union{Function,Nothing}=nothing) = eigen(Matrix(A), Matrix(B);sortby) ``` in...

I am not the developer of this package, but I have been using it for the past year or so. The ABCDE method was in v1 of this package but...

This PR passes the relevant tests, can it be merged? This is an old bug that has had other PRs to fix it: https://github.com/JuliaStats/Clustering.jl/pull/99

Hm, not sure why that change broke the test. Sorry about that, I did test it locally before suggesting it and it was fine.