Peter Vahlstrup comments

Results 12 comments of


                                            Peter Vahlstrup

Concurrency issues

Happy to help :) > Switching to a ConcurrentHashMap would prevent the possibility of seeing an incoherent state of the underlying map in this situation, but it would not make...

Two join tables are created for many-to-many relations instead of one

I reported this in #12652 where it was stated to be preparations for versioning?

`getEnabledPlugins`fails silently when package can not be resolved

Maybe more finegrained error handling is needed before stopping execution og printing an error. If as an example we have a `package.json` like this ``` { "exports": { ".index.js": "./index.js"...

Do not "simplify" returned route

Try to lower the tolerance option

Allow opt-in explicit dependency tracking for `$effect`

I use a similar pattern when e.g. a prop change, this would also benifit from being able to opt in on what to track instead of remembering to untrack everything....

Allow opt-in explicit dependency tracking for `$effect`

Thanks @ottomated, that seems reasonable. The inverse of `$untrack()` would still make sense though as you initially suggested. Maybe something like ```js $track([dep1, dep2], () => { // do stuff...

Mixing default and named exports makes i hard to import

Thanks for the nice offer I am currently wrapping up the project where I used geojson-path-finder and am moving on to a new project without a path-finder requirement, so I...

Getting a path along a river on a LineLayer with multiple rivers?

If the original lines' vertices snap it should work without adjusting the tolerance

Getting a path along a river on a LineLayer with multiple rivers?

It is not enough that the vertex of one line snaps to the somewhere on another line between two vertices on that line. They need to meet on a vertex....

Getting a path along a river on a LineLayer with multiple rivers?

Yes, to get accuracy the lines need to have the same vertices. Increasing tolerance expands the radius so two vertices close to each other is considered equal but this the...