Matt Parrish
Matt Parrish
How do you propose cloning the element? And I'd have to do that from within `jest-glamor-react`, right? Additionally, we've already planned to migrate from Glamorous to Emotion, so I might...
I no longer get the error output, but the cloned node doesn't get the children - it just becomes an empty DOM element.
Dropping down to redux-thunk is less than ideal, though. It's such a general API and allows devs/teams too much power to make bad decisions. It would be awesome to see...
This pull request is based off https://github.com/petehunt/jsx-loader/pull/30 with merge conflicts addressed.
I haven't tried that, but have heard @thejameskyle and @kentcdodds saying good things about that. I'd be up for trying that out and learning what the differences are.
I've actually just started on this work. It'll behave the same way as what's there now, just using `babel-codemod` instead of `jscodeshift`.
There will be no change to how the files are generated.
I don't think it's rude to modify the original code, because these model files exist in order to support the code generation. They go hand-in-hand. I don't think we should...
I'm fine with that, although I think the import comments are unnecessary.
Yeah, you're right. I'll put together a pull request to add `toJSON` as a shallow operation which will work better when using `JSON.stringify`