Pranav Bhandari comments

Results 15 comments of


                                            Pranav Bhandari

failed to build CacheLib following document

@gaowayne please try our new build using 'getdeps' and see if the build fails. Please open another issue if the build does not work.

use toString when print Status

Thanks for the PR! Closing this since the recent build is good.

Are admission policies applied to objects (value changes in DRAM) even if they are read from the NVM cache?

I am not sure what do you mean by users can finally read old data. There is an updated version in the DRAM cache so it will always be returned...

Are admission policies applied to objects (value changes in DRAM) even if they are read from the NVM cache?

What you might be missing is that the moment the object that is in DRAM and also NVM updated in DRAM cache (Step 3), the item in NVM is invalidated...

Build is failing with error: ‘fmt::v10::detail::type_is_unformattable_for<const facebook::cachelib::navy::Status, char> _’ has incomplete type 1600 | type_is_unformattable_for<T, typename Context::char_type> _; | ^

This should be fixed now.

[Seeking Volunteers] Add new builds to CacheLib

@vaavaav We are now using 'getdeps' to sync stuff across OSS projects. We would love for you to volunteer to improve out builds. I will close this for now as...

NavySetup should not involve the MockDevice

The build works now. The CMakeLists has been fixed along with the FDP tests. The FDP tests only run when FDP is enabled in the system.

Build failed with error message "cachelib/navy/common/FdpNvme.h:143:28: error: expected ‘)’ before ‘&’ token 143 | explicit FdpNvme(NvmeData& data, struct nvme_fdp_ruh_status* ruh_status); | ~ ^ | ) make[2]: * [navy/CMakeFiles/cachelib_navy.dir/build.make:328: navy/CMakeFiles/cachelib_navy.dir/common/Device.cpp.o] Error 1 make[1]: * [CMakeFiles/Makefile2:395: navy/CMakeFiles/cachelib_navy.dir/all] Error 2 make: *** [Makefile:130: all] Error 2 build-package.sh: error: make failed"

Is this issue still occurring? The recent fixes might have mitigated this. I will close this if it is not a problem anymore or if I don't hear back in...

Build failed with error message "cachelib/navy/common/FdpNvme.h:143:28: error: expected ‘)’ before ‘&’ token 143 | explicit FdpNvme(NvmeData& data, struct nvme_fdp_ruh_status* ruh_status); | ~ ^ | ) make[2]: * [navy/CMakeFiles/cachelib_navy.dir/build.make:328: navy/CMakeFiles/cachelib_navy.dir/common/Device.cpp.o] Error 1 make[1]: * [CMakeFiles/Makefile2:395: navy/CMakeFiles/cachelib_navy.dir/all] Error 2 make: *** [Makefile:130: all] Error 2 build-package.sh: error: make failed"

This is resolved. Please try again and let us know if there are any issues.

Fix typo

Thank you for the PR! Closing this since it does not allow me to merge. Could you submit this again? Sorry for the issue.