Peter Cornell comments

Results 27 comments of


                                            Peter Cornell

integrate with the cross-language consensus test harness

this is a "nice to have" for V3

add flush() and finish() methods to the Writer interface

Related to #396

merge IonType and TypeCodes

IonBinary.ts also has a set of `TB_*` consts that are redundant, and should be consolidated.

Need to remove all undefined behavior logic to throw early

Impl shouldn't check (or rely upon) `undefined`. Consider use of `undefined` to be a bug; use `null` (or a value) instead. Note that some APIs currently return `undefined`; update to...

IonDecimal returns float representation in toString()

Note that ion-java's `Decimal.toString()` may also return a string containing 'E': ```java IonReader reader = IonReaderBuilder.standard().build("123d1"); reader.next(); System.out.println(reader.decimalValue()); ``` produces: ``` 1.23E+3 ```

Reader interface doesn't have a close() method -- should it?

Sizing assumes the Reader is not re-usable after `close()`

Reader interface doesn't have a close() method -- should it?

Related to https://github.com/amzn/ion-js/issues/396

add reader.toString()

That's the way to do it today. Reader is basically an iterator, so `Reader.toString()` would seem strange to me; perhaps a helper function would make sense.

consider defining and throwing custom error classes

A few thoughts: * a well-named error class provides a little more information to the receiver * in cases where a method's implementation might have multiple error conditions, throwing a...

consider defining and throwing custom error classes

per @almann in #307: > We really should consider having some first-class error type like IonError and have it prototype extend Error. Since we're targeting ES6, this is pretty straightforward,...