Pavel Fomin comments

Results 6 comments of


                                            Pavel Fomin

Coverage on the new / modifies files

I've also noticed that the coverage does report an increase / decrease. Does Projektor compare the coverage with a previous build on the same branch?

Generic templates not tied to a structure support

Good point. I didn't realize that the display templates can be accessed via `Manage Data Definitions -> Actions -> Templates`. I've followed the `liferay` instructions and added the `display template`...

TO_JSON_STRING with DATE field does not produce valid JSON - quotes missing

Thank you @ohaibbq! I can confirm that the fix is working on our side.

java.lang.NullPointerException: Cannot invoke "com.google.cloud.bigquery.TableId.getProject()" because "tableId" is null

When I tried using "ghcr.io/recidiviz/bigquery-emulator:0.4.4-recidiviz.26" to instantiate `BigQueryEmulatorContainer` ``` BigQueryEmulatorContainer container = new BigQueryEmulatorContainer("ghcr.io/recidiviz/bigquery-emulator:0.4.4-recidiviz.26") ``` I got this init error from test containers: ``` Caused by: java.lang.IllegalStateException: Failed to verify...

java.lang.NullPointerException: Cannot invoke "com.google.cloud.bigquery.TableId.getProject()" because "tableId" is null

That worked, thank you for pointing this out. I also verified that running application locally with `docker-compose` using `ghcr.io/recidiviz/bigquery-emulator:0.4.4-recidiviz.26` works as expected. Thank you for making this fix. Looking forward...

java.lang.NullPointerException: Cannot invoke "com.google.cloud.bigquery.TableId.getProject()" because "tableId" is null

Looks like this fix has also been included in ghcr.io/recidiviz/bigquery-emulator:0.6.6-recidiviz.1