Paulius

Results 8 issues of Paulius

When minting token id starts from 1, not 0: https://github.com/Anish-Agnihotri/MultiRaffle/blob/a468d0029138ec0166e9e43697c4053c340d7e13/src/MultiRaffle.sol#L223 functions that depend on tokenId, e.g. tokenURI will return unrevealed data for id 0.

- Break search of metadata to reduce gas usage. - Owner can customize the LINK fee in case a different value will be required in the future. - Error message:...

Consider marking functions with a specific access level, for example, functions that aren't called internally, please mark with a keyword "external". Calling external function consumes less gas than public function....

Consider adding "indexed" keyword next to the event parameter. The indexed parameters allow filtering events by specific addresses. For example, event AuctionCreated(uint256 tokenId, uint256 startingPrice, uint256 endingPrice, uint256 duration); //make...

Let's rescue NFTs also!

### Description Consider adding "indexed" keyword next to the event parameters like address, IDs, etc. The indexed parameters allow filtering events by a specific value. ### Impact This is only...

### Description OffersAccessControl.sol has a function withdrawTotalLostAndFoundBalance() with the onlyLostAndFound modifier which checks if the msg.sender is the lostAndFoundAddress: `require(msg.sender == lostAndFoundAddress, "only LostAndFound is allowed to perform this operation");`...

### Description As the gas inefficiencies are also in the scope, I would like to suggest packing variables in struct more efficiently. OffersBase.sol has an Offer struct: ``` struct Offer...