Paul Iacomi
Paul Iacomi
Hi Kitkim, Since my research involves gas/vapour isotherms, that was the main driver behind the framework. However, I'd love to see it extended it to the liquid phase if possible!...
Hi @Kitkim160, I looked a bit into it over the last few days and here is what I think: We can just consider the liquid isotherm as a single component...
No need, we can do a proper release when needed. Clone latest dev branch and create a new branch following the git flow model, e.g. feature/excess_absolute. Can then PR that...
Hi, I'm aware that this is a shortcoming of the program in the current state. The kernel provided was calculated by a collaborator at my former institution (MADIREL) and therefore...
Perfect, I will have a look ASAP. Would it also be possible to write a few tests that would ideally cover the main functionality with known input/outputs? Look in `./test/characterization/test_x.py`...
Very interesting graph, really highlights the pain points of the Clapeyron method. Also, great match! Perhaps this would be best introduced as an example interactive notebook? These are more advanced...
Could you also pull in the latest changes from the master branch? Tests on python
There were some conflicts at one point which were not merged. Check the leftover in `tests/characterisation/test_whittaker_enthalpy.py`
Hi @sblanky, did you have the time to look at the code after last discussion?
No worries, thesis is the priority for sure, just wanted to check :)