Paul Hammond
Paul Hammond
I just spent a few minutes looking into this. I think there are two main challenges here (aside from your lack of a OS X machine): Firstly, the FSEvents API...
Good point - I usually avoid cgo based code because it makes cross compilation much harder, if not impossible. That's not a good reason to not offer FSEvents when available....
Full error message: ``` webkit2png https://news.bbc.co.uk Fetching https://news.bbc.co.uk ... 2020-03-25 17:50:11.210 Python[47261:1737712] *** WebKit discarded an uncaught exception in the webView:didFinishLoadForFrame: delegate: [ valueForUndefinedKey:]: this class is not key value...
I'm really sorry, I have no idea how this pull request slipped through the cracks. This is a great solution to the problem. I've just proposed [some much bigger changes](https://github.com/paulhammond/webkit2png/pull/66#issuecomment-35409624)...
I like the idea a lot! But... I don't know when I'll get time to do it. If anyone else can work out how to do it I'll definitely help...
I don't like the cookie file as a user interface - ideally we'd accept cookie name/value pairs on the command line and use that to generate a cookie header manually...
@aperlscript Thanks for the updated code - having both as an option works for me. I just left one question as a code comment... Also, before merging this I'd like...
(Also, don't worry about the part where this pull request will no longer automatically merge, I'll deal with that when it's ready)
Thanks for submitting this fix. I tried it on my Mac (Catalina, 10.15.3) which has pyobjc 2.5.1 installed, and I get this error: ``` Traceback (most recent call last): File...
Huh. I just spent a little while trying to get this to work and something about retina support in Mac OS and the widespread trend towards responsive design has caused...