Paul Maréchal

Results 80 comments of Paul Maréchal

Managed to find a way to do without the new `TypedCommand` type and keep the changes backward compatible.

Using the following `package.json` ```json { "name": "theia-app-example", "version": "1.0.0", "main": "index.js", "license": "MIT", "dependencies": { "@theia/core": "^1.28.0", "@theia/plugin-ext": "^1.28.0", "@theia/plugin-ext-vscode": "^1.28.0" }, "devDependencies": { "@theia/cli": "^1.28.0" } } ```...

Otherwise I tried polluting my example app by adding `@theia/[email protected]` to force a duplication and it was correctly picked up. I think it should be good to merge once my...

I happened to write a generator function and noticed that this type exists, figured we could use it in the relevant places. I find it more readable than the mouthful...

I wanted to try out this PR to run benchmarks, but plugins don't seem to work anymore. I am running Windows 10.

@tsmaeder I just pulled the branch as is and built it, I didn't think I had to rebase myself?

~~See https://github.com/eclipsesource/theia/pull/48 for a potential fix for Windows.~~ edit: Obsolete, see new comment.

> yarn install v1.22.19 > $ node-gyp install > gyp info it worked if it ends with ok > gyp info using [email protected] > gyp info using [email protected] | win32...

See https://github.com/nodejs/node-gyp#on-windows

I'm just surprised that you are having this issue as I have been developing for Theia on Windows for quite some time now, and recently had to help interns setup...