Patrick Zheng

Results 21 comments of Patrick Zheng

> @yizha1 Similar to my comments in [#304 (comment)](https://github.com/notaryproject/notation/issues/304#issuecomment-1293593766), I suggest updating `Sign success` to `Sign succeeded`. This is more commonly used. > > Another question, Notation has supported two...

Reopened because the implementation of this issue ([PR 450](https://github.com/notaryproject/notation/pull/450)) is not merged yet.

Reopened because the implementation of this issue (https://github.com/notaryproject/notation/pull/450) is not merged yet.

Will take this one. @yizha1 @FeynmanZhou Do we want it in 1.0 or after 1.0?

@FeynmanZhou By reading through your issue description, I have the following question: One could run `notation cert generate-test` for multiple times and each time with a different key name. Should...

> @patrickzheng200 This cleanup flag is used to delete the specified source key/cert. We need to add an argument `` when using this flag. I will update the Notation CLI...

> IMO, adding key and cert to signingkey.json manually is not a regular manipulation although technically it is allowed. Given the case above, I think `notation cert generate-test --cleanup alpine2`...

> The following command `notation cert generate-test --cleanup ` does not make too much sense for me. The command is to "generate" something but we are adding switch to "cleanup"....

> @patrickzheng200 your proposal makes more sense. Is the expectation that only "test" pairs are cleaned up? Although unlikely, there may be some odd usage where the key and the...

Just posting the contexts of why we should have a `notation policy init` command: For a 0-experience starter, `find our specs -> find a trust policy template -> learn how...