Patrick Lafrance comments

Results 164 comments of


                                            Patrick Lafrance

UnhandledPromiseRejectionWarning: TypeError: match.loader.options.plugins is not a function

@jawadsh123 you should submit a PR to CRACO instead ;) If it's backward compatible, I could release it without waiting for full support of CRA 5.

Default Values prevent warning

It seems to work fine for literals, which is awesome. I wonder if it could also work for const var? I have the following use case which doesn't get sorted:...

🐛 The Button loading state does not prevent onClick

Shopify Polaris is using internally a [use-disable-interaction](https://github.com/Shopify/polaris/blob/main/polaris-react/src/utilities/use-disable-interaction.ts) hook to provide this behavior to components. We could do something similar.

💡 Avatar has a default look when no name is provided

Pretty sure we already had this discussion a few months ago and we concluded that it doesn't make sense in our apps to have an avatar without a name?

💡 Avatar has a default look when no name is provided

It could be added to Orbit. I would also like to know more about the use cases. I am not aware of every use cases in the apps, as far...

💡 Avatar has a default look when no name is provided

Got it, so an O365 user can exist without a name?

💡 Avatar has a default look when no name is provided

So the use case is the UserMenu in the navbar?

🐛 Transition animations doesn't seem to work on mobile

You should try to setup a sandbox to test this yourself to optimize your dev flow. Would also allow you to test the other components for similar problems on iphone.

🐛 Transition animations doesn't seem to work on mobile

Tools like browserstack

🐛 Unexpected behaviour when Tile contains a href and is disabled

Thanks for the issue. Sadly, since it's a link we can't do anything, we only manage the style. It's your responsability to handle the "disabled" behavior. You should ask your...