Patrick Nicodemus
Patrick Nicodemus
> This looks pretty good to me. Aside from the points I mentioned specifically, I think a better name for the file would be something like `Spaces/Nat/Arithmetic`. Ok, done.
> I'm not really able to review the overall approach here. My comments are mainly minor stylistic issues. (Also, this appears to be WIP. Maybe mark it as "draft" until...
@mikeshulman Ok, I got overly excited. SProp and BooleanReflection stuff deleted from the commit so we can just talk about natural number arithmetic stuff, I will open a second PR...
@mikeshulman Your original "changes requested" applied to an early draft of this PR before I threw out a bunch of independent things like stuff related to boolean reflection or SPRop....
I would like to bump this feature request as I have a use-case for it.
This would be very helpful. At the moment one of the barriers for me is apparently dependence on matplotlib < 3.4.3, which is seemingly (?) incompatible with Python 3.10.
@tmcgilchrist I cloned your branch and ran the tests and everything passes. Based on your experience, what else do you feel needs to be done before this can be merged?...
I have a vague understanding of what a preterm is but what are the most important properties of preterms that end users need to know about? Is there any discussion...
I can reproduce this bug on my machine as well. I can supply additional information or context if needed, and I can test fixes
> If the problem is windows, it's possible it will be solved by numpy 2.0. Not sure how easy the upgrade path to numpy 2.0 will be, however. > >...