Patric K.

Results 8 comments of Patric K.

> @patkje75 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. > > ``` > @microsoft-github-policy-service agree [company="{your company}"] >...

Sorry, I had to down prioritize this due to a hectic schedule, I hope I can look into this and update the requested changes within the coming weeks.

Sorry for the delay I have had a very busy time and I will soon be out for a while. I hope I have adressed all you comments.

@sebassem deploying the resources work, however the deployment script fails ![image](https://github.com/microsoft/finops-toolkit/assets/5085382/64b026c3-45d8-49bc-adac-25fc77c3407b) It tries to access the FinOps storage account . I haven't had the time to look into all changes...

You were right, it was the DNS, we have policies managing registration of private endpoints to the private DNS zones and it hadn't applied yet. I was trying to do...

Too fast, I saw the pipeline kick off and left, today I see that i failed. ![image](https://github.com/microsoft/finops-toolkit/assets/5085382/00a35473-8ff7-4121-a945-036f43ffdb60) `Operation on target Convert CSV failed: ErrorCode=MappingColumnNameNotFoundInSourceFile,'Type=Microsoft.DataTransfer.Common.Shared.HybridDeliveryException,Message=Column 'AvailabilityZone' specified in column mapping cannot...

> A few questions, since I don't have enough context on private endpoints: > 1. The `subnetResourceId` and `integrationRuntimeSubnetResourceId` parameters both point to existing resources, correct? Correct, these must exists....

@flanakin I made the change in the branch `features/private` but I wasn't allowed to push it. Should I create a new branch or how should I do it?