Suraj Patil

Results 10 comments of Suraj Patil

Along with this changes we will also need to add `CLUSTER_RESTAPI_HTTPLISTENMULTIADDRESS=/ip4/0.0.0.0/tcp/9094` in configure-script - [controllers/scripts/config.go](https://github.com/ipfs-cluster/ipfs-operator/blob/main/controllers/scripts/config.go#L89) and same as environment variable in statefulset - [controllers/statefulset.go](https://github.com/ipfs-cluster/ipfs-operator/blob/404e3ca9c362475de4e9b451cf6c436b13cb1b42/controllers/statefulset.go#L192)

Yes, I agree we can use plain old minio client but we are anyway creating the bucket object to perform other tasks like downloading `meta.json` of tsdb, adding thanos external...

Yes, I meant we use objstore for downloading and uploading of files. I was just thinking to reuse the minio client config which is already generated in objstore. But no...

ok Thanks @MichaHoffmann Another issue is this [parseConfig](https://github.com/thanos-io/objstore/blob/main/providers/s3/s3.go#L169) method is also private. We might need to rewrite it again in our codebase to parse the s3 config yaml which is...

All the PR checks are failing because go version has been updated. go version is auto updated by `go mod tidy` because the new dependency `github.com/thanos-io/thanos` uses go 1.22.0

Thanks for the review @saswatamcode Regarding disconnected env - In case of ROS, OpenShift cluster/cost-operator will not directly upload the tsdb blocks to obs-api. It uploads it first to an...

Hello @moadz, Thanks for reviewing the PR. I got the first point of your suggestion regarding the getSignedUrl endpoint but didn't completely understand the 2nd point. Particularly I didn't understand...

Hello, I got the answers for above questions please ignore it. I have doubt regarding `{tenant_id}/metrics/api/v1/blocks/mark?block-id={SOME_BLOCK_ID}` API. How do we mark a block 'ready for querying' OR 'not ready for...

Thanks @moadz Got your point. Regarding Thanos Compactor, Do you think thanos compactor can cause any issue here? I mean time between the block is uploaded and the mark API...

Closing this PR as it is no longer required.