Patrick Schmitt
Patrick Schmitt
For some glaciers the number of trapezoid grid points of the `model_flowlines` change depending on the `prepro-border`. For the elevation band flowlines it is expected (as far as I know/believe)...
Some MassBalanceModels rely on the year of `t_star` if no `y0` is provided (see [here](https://github.com/OGGM/oggm/blob/master/oggm/core/massbalance.py#L652), [here](https://github.com/OGGM/oggm/blob/master/oggm/core/massbalance.py#L852), [here](https://github.com/OGGM/oggm/blob/master/oggm/core/massbalance.py#L951) and [here](https://github.com/OGGM/oggm/blob/master/oggm/core/massbalance.py#L1249)), but with the new glacier by glacier calibration to geodetic measurements...
The changes of the PR https://github.com/OGGM/oggm/pull/1425 need to be included in the Documentation and Tutorials: - [x] general ideas of dynamic calibrations (maybe a new chapter **Model initialisation** where **dynamic...
The dynamic numeric core of OGGM is creating instabilities under certain conditions (this is a known problem for long, e.g. see https://oggm.org/2020/01/18/stability-analysis/ or https://oggm.org/2020/07/08/numerics/, or the issues https://github.com/OGGM/oggm/issues/909 and https://github.com/OGGM/oggm/issues/860)....
I just saw that the default maximum limit for mu_star is 10000 (see https://github.com/OGGM/oggm/blob/master/oggm/params.cfg#L219), but from the explanation above I think it should be rather 1000. Or is there a...
It just came to my mind that I used the oggm ice density (900 kg m-3) when I calculate the modelled geodetic mass balance in the dynamic mu star calibration,...
Here I add a new kwarg to the dynamic mu star calibration to provide `geodetic_mb_ice_density`. Previously it used an ice density of 900 kg m-3 when calculating the modelled geodetic...
This is related to https://github.com/OGGM/oggm/pull/1674 and includes some minor changes in `merge_gridded_data` and `merge_simulated_thickness`. - [ ] Tests added/passed - [ ] Fully documented - [ ] Entry in `whats-new.rst`
Some plotting functionalities of `oggm.graphics` can plot results of multiple gdirs by using `extend_plot_limit=True`. With the changes of https://github.com/OGGM/oggm/pull/1674, it would now be possible to also add topography to those...
Here is a suggestion for deleting `required_model_steps` from `FlowlineModel` as a potential optimisation as discussed on slack. I kept some of the logic to make sure the mass balance model...