parham saremi
parham saremi
any update? :)
> Ummm I remember the first commit being only fixes to what janus wrote. the second commit is what you tasked me to do :thinking:
> > the second commit is what you tasked me to do thinking > > Separation is not needed just because one commit is from one author and another commit...
> > In the end, I used his code. I think I should merge commits then > > Sure let's do it. BTW let's rather use the word "squash", not...
> > Co-authored-by: parhamsaremi [[email protected]](mailto:[email protected]) > > Nit, the bit before the e-mail address should be in Name Surname format, not username. Unless you have anything against that? hmmmm OK...
https://github.com/mauriciosantos/Buckets-JS/pull/23 i added this feature by updating the signature to inorderTrverse(callback, element = undefined)
https://github.com/mauriciosantos/Buckets-JS/pull/23 i tried to remove the redundant line and fix the function
> I don't like this error "funder didn't confirm to lock the funding!". geewallet user doesn't know what funder or fundee means. Do you have any suggestions for the replacement?...
> Yeah I know we already have some strings that use that term, but I was never convinced about them so I'm taking this opportunity to review this. @aarani how...
> What's the reason for the PR title & description to not match the commit title and body? Hmm I didn't like how after adding the DRAFT there were two...