Sebastián Galkin comments

Results 10 comments of


                                            Sebastián Galkin

@ getting a little redundant with nesting

Thanks for reporting this, it's very interesting. Do you have any idea for a better syntax that covers this case? Please, if you make any changes, start with the 0.3.0...

Requiring types %

I'll take a look at this next week. Thanks for reporting the issue

Reformat code w/ spaces

maybe using git hooks until that happens?

mkPoetryEnv does not create egg-info metadata correctly

Is there a more definitive solution to this issue?

Make methods of abstract base class async

I think a better type for these functions would be: ```python async def list(self) -> AsyncIterator[str]: ``` Most implementations probably won't need these functions to be async, but it's a...

Make methods of abstract base class async

> ~All current child classes use the `prefix` argument. I don't think it should be removed.~ Sorry, I just missed the argument in the example, definitely we shouldn't drop it....

Make methods of abstract base class async

> As for the AsyncGenerator → AsyncIterator change, how about addressing it in an issue and a separate PR? It's definitely not a big deal, `AsyncGenerator[str]` also works. But, doing...

Consider changing default `consolidated=None` to `False` for zarr_version=3 in `to_zarr()`

> to have xarray check store.supports_consolidated_metadata and consolidate by default if that returns True. An important detail: `store.supports_consolidated_metadata` is a cheap non I/O method. Essentially, all current Stores will return...

Make the `ByteRangeRequest` more literate

This would be a good opportunity to think if we should also consider a type that allows doing things like "last N bytes" (without knowing the size beforehand). Most (all?)...

Make the `ByteRangeRequest` more literate

That is great, then making this type more clear is even more important.