Wilfried OLLIVIER comments

Results 23 comments of


                                            Wilfried OLLIVIER

fix(inputs.mongodb): add an option to by pass connexions error on init

> My comments about moving the connect to mongo from the `Init` to the `Start` method still counts. Oh yes, sorry. Will fix. _Edit: fixed_

fix(inputs.mongodb): add an option to by pass connexions error on init

Here is a refactor, I did not find an example of the `Start` function, so not sure if correct. If not correct, can you provide some example ? Thanks a...

fix(inputs.mongodb): add an option to by pass connexions error on init

> Looks good overall, but shouldn't the ping then also be done at the start of the gathering for the server, it will reduce the amount of errors every gather...

fix(inputs.mongodb): add an option to by pass connexions error on init

LGTM, i will implement it asap !

fix(inputs.mongodb): add an option to by pass connexions error on init

Damn sorry ! Thanks a lot for the feedback :+1:

fix(inputs.mongodb): add an option to by pass connexions error on init

There is just one behavior left we may want to discuss : When `Gather` is called on an unreachable server it waits a very looong time before returning back an...

fix(inputs.mongodb): add an option to by pass connexions error on init

@Hipska I changed the wording from "retry" to "skip", I also find it more clear. Thanks.

fix(inputs.mongodb): add an option to by pass connexions error on init

> Do you mean this is the current default behaviour? I think that's good, they can change to retry when they don't want that. But when thinking about that, "retry"...

Give Compose mascot a name

Octopush

Elasticsearch exporter

Hi 👋 ! I'm interested by this issue, can I take it ? Thanks !