papasmile

Asslaam alaykum wa rahmatullah, Nice idea! Firstly, as JSON files are supported via their own plugin in ESLint: "you should run prettier over your json files in a separate step...

Assalaam alaykum, I'd also be happy to assist, you @njmulsqb. My PR was closed with no justification... but willing to give another go.

Salam, @meezaan are you talking about e.g: https://github.com/islamic-network/api.aladhan.com/blob/fcaa0630e0c110978ecbae2095303c39d5cfdcd3/routes/timings/v1/prayerTimes.php#L84 I don't see any corresponding /{date} routes... sorry, can you explain a bit?

OK, gotcha, so lazy coding resulting a non-idempotent results (thus non-cacheable). First off, I'm thinking that route probably should not accept a timestamp since results are always based on a...

Salam, @meezaan, I was referring to your statement "we compute the date, and do a 301". That is, we still need to * dynamically * convert whatever timestamp they send...

Salam, @meezaan couple questions: 1) Are you talking about timings/v1/prayerTimes.php, timings/v1/dateAndTime.php, or other routes as well? 2) Are you thinking to change the * output * of any of those...

Hi, same for me. Just looking into code, it seems like minifying is not supported for standard input? Using `-i-` per above triggers 'simple mode': https://github.com/wycats/handlebars.js/blob/fd3ca85d136d9f7f11faeda2fbcb3fd56f05cf42/lib/precompiler.js#L175 Which skips adding surrounding...

Would that go like maybe under integrations? https://handlebarsjs.com/installation/integrations.html

Seems that only applies to routes * under * /play etc with params. In any case perhaps just showing an error message on location field (similar to #14) would be...

Also, what are /a/b routes for? They don't seem to be used... can those be deleted or maybe need an enhancement issue? https://github.com/islamic-network/aladhan.com/blob/f465f37438a07f4687384c3e8f33fbdf10d97223/src/routes.php#L420